set_elem: Copy user data memory

All attributes are passed by copy, so user data should be copied too.

Signed-off-by: Carlos Falgueras García <carlosfg@riseup.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

diff --git a/src/set_elem.c b/src/set_elem.c
index 990be2461a734111f1b22a1df6f3625295a00b21..b9c7e1e728308dfc590721fb5c2c950fd5cfe7ac 100644 (file)
--- a/src/set_elem.c
+++ b/src/set_elem.c
@@ -125,8 +125,14 @@ void nftnl_set_elem_set(struct nftnl_set_elem *s, uint16_t attr,
                s->timeout = *((uint64_t *)data);
                break;
        case NFTNL_SET_ELEM_USERDATA: /* NFTA_SET_ELEM_USERDATA */
-               s->user.data = (void *)data;
-               s->user.len  = data_len;
+               if (s->user.data != NULL)
+                       xfree(s->user.data);
+
+               s->user.data = malloc(data_len);
+               if (!s->user.data)
+                       return;
+               memcpy(s->user.data, data, data_len);
+               s->user.len = data_len;
                break;
        default:
                return;