]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
irqchip/renesas-rzv2h: Switch to using dev_err_probe()
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Wed, 4 Mar 2026 11:33:13 +0000 (11:33 +0000)
committerThomas Gleixner <tglx@kernel.org>
Tue, 10 Mar 2026 17:34:51 +0000 (18:34 +0100)
Make use of dev_err_probe() to simplify rzv2h_icu_probe_common().

Keep dev_err() for -ENOMEM paths, as dev_err_probe() does not print for
allocation failures, ensuring they remain visible in logs.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260304113317.129339-4-prabhakar.mahadev-lad.rj@bp.renesas.com
drivers/irqchip/irq-renesas-rzv2h.c

index 766b981cf3d8d77daef3376795279fd2c7611149..444da7804f15bdf80cb5e3c894ec8e8afb7b4878 100644 (file)
@@ -560,10 +560,8 @@ static int rzv2h_icu_probe_common(struct platform_device *pdev, struct device_no
        int ret;
 
        parent_domain = irq_find_host(parent);
-       if (!parent_domain) {
-               dev_err(dev, "cannot find parent domain\n");
-               return -ENODEV;
-       }
+       if (!parent_domain)
+               return dev_err_probe(dev, -ENODEV, "cannot find parent domain\n");
 
        rzv2h_icu_data = devm_kzalloc(dev, sizeof(*rzv2h_icu_data), GFP_KERNEL);
        if (!rzv2h_icu_data)
@@ -576,29 +574,20 @@ static int rzv2h_icu_probe_common(struct platform_device *pdev, struct device_no
                return PTR_ERR(rzv2h_icu_data->base);
 
        ret = rzv2h_icu_parse_interrupts(rzv2h_icu_data, node);
-       if (ret) {
-               dev_err(dev, "cannot parse interrupts: %d\n", ret);
-               return ret;
-       }
+       if (ret)
+               return dev_err_probe(dev, ret, "cannot parse interrupts\n");
 
        resetn = devm_reset_control_get_exclusive_deasserted(dev, NULL);
-       if (IS_ERR(resetn)) {
-               ret = PTR_ERR(resetn);
-               dev_err(dev, "failed to acquire deasserted reset: %d\n", ret);
-               return ret;
-       }
+       if (IS_ERR(resetn))
+               return dev_err_probe(dev, PTR_ERR(resetn), "failed to acquire deasserted reset\n");
 
        ret = devm_pm_runtime_enable(dev);
-       if (ret < 0) {
-               dev_err(dev, "devm_pm_runtime_enable failed, %d\n", ret);
-               return ret;
-       }
+       if (ret < 0)
+               return dev_err_probe(dev, ret, "devm_pm_runtime_enable failed\n");
 
        ret = pm_runtime_resume_and_get(dev);
-       if (ret < 0) {
-               dev_err(dev, "pm_runtime_resume_and_get failed: %d\n", ret);
-               return ret;
-       }
+       if (ret < 0)
+               return dev_err_probe(dev, ret, "pm_runtime_resume_and_get failed\n");
 
        raw_spin_lock_init(&rzv2h_icu_data->lock);