xfs: set max_agbno to allow sparse alloc of last full inode chunk

Sparse inode cluster allocation sets min/max agbno values to avoid
allocating an inode cluster that might map to an invalid inode
chunk. For example, we can't have an inode record mapped to agbno 0
or that extends past the end of a runt AG of misaligned size.

The initial calculation of max_agbno is unnecessarily conservative,
however. This has triggered a corner case allocation failure where a
small runt AG (i.e. 2063 blocks) is mostly full save for an extent
to the EOFS boundary: [2050,13]. max_agbno is set to 2048 in this
case, which happens to be the offset of the last possible valid
inode chunk in the AG. In practice, we should be able to allocate
the 4-block cluster at agbno 2052 to map to the parent inode record
at agbno 2048, but the max_agbno value precludes it.

Note that this can result in filesystem shutdown via dirty trans
cancel on stable kernels prior to commit 9eb775968b68 ("xfs: walk
all AGs if TRYLOCK passed to xfs_alloc_vextent_iterate_ags") because
the tail AG selection by the allocator sets t_highest_agno on the
transaction. If the inode allocator spins around and finds an inode
chunk with free inodes in an earlier AG, the subsequent dir name
creation path may still fail to allocate due to the AG restriction
and cancel.

To avoid this problem, update the max_agbno calculation to the agbno
prior to the last chunk aligned agbno in the AG. This is not
necessarily the last valid allocation target for a sparse chunk, but
since inode chunks (i.e. records) are chunk aligned and sparse
allocs are cluster sized/aligned, this allows the sb_spino_align
alignment restriction to take over and round down the max effective
agbno to within the last valid inode chunk in the AG.

Note that even though the allocator improvements in the
aforementioned commit seem to avoid this particular dirty trans
cancel situation, the max_agbno logic improvement still applies as
we should be able to allocate from an AG that has been appropriately
selected. The more important target for this patch however are
older/stable kernels prior to this allocator rework/improvement.

Cc: stable@vger.kernel.org # v4.2
Fixes: 56d1115c9bc7 ("xfs: allocate sparse inode chunks on full chunk allocation failure")
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Carlos Maiolino <cem@kernel.org>

diff --git a/fs/xfs/libxfs/xfs_ialloc.c b/fs/xfs/libxfs/xfs_ialloc.c
index d97295eaebe631e8f0166a3f9470d319cd459d3f..c19d6d713780ca20494cb665ad106e060b4ca443 100644 (file)
--- a/fs/xfs/libxfs/xfs_ialloc.c
+++ b/fs/xfs/libxfs/xfs_ialloc.c
@@ -848,15 +848,16 @@ sparse_alloc:
                 * invalid inode records, such as records that start at agbno 0
                 * or extend beyond the AG.
                 *
-                * Set min agbno to the first aligned, non-zero agbno and max to
-                * the last aligned agbno that is at least one full chunk from
-                * the end of the AG.
+                * Set min agbno to the first chunk aligned, non-zero agbno and
+                * max to one less than the last chunk aligned agbno from the
+                * end of the AG. We subtract 1 from max so that the cluster
+                * allocation alignment takes over and allows allocation within
+                * the last full inode chunk in the AG.
                 */
                args.min_agbno = args.mp->m_sb.sb_inoalignmt;
                args.max_agbno = round_down(xfs_ag_block_count(args.mp,
                                                        pag_agno(pag)),
-                                           args.mp->m_sb.sb_inoalignmt) -
-                                igeo->ialloc_blks;
+                                           args.mp->m_sb.sb_inoalignmt) - 1;
 
                error = xfs_alloc_vextent_near_bno(&args,
                                xfs_agbno_to_fsb(pag,