]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Fix dnssec-signzone and dnssec-verify logging
authorMark Andrews <marka@isc.org>
Wed, 23 Dec 2020 01:21:24 +0000 (12:21 +1100)
committerMark Andrews <marka@isc.org>
Mon, 4 Jan 2021 03:59:10 +0000 (03:59 +0000)
The newlines need to be appended to the messages generated by report
in a atomic manner.

bin/dnssec/dnssec-signzone.c
bin/dnssec/dnssec-verify.c

index c33be78a5a2efca50ae24cd19fddcd63e6653e8a..2337ec99b367f9dec74519b97ffd30b147c49469 100644 (file)
@@ -2728,10 +2728,13 @@ static void
 report(const char *format, ...) {
        if (!quiet) {
                FILE *out = output_stdout ? stderr : stdout;
+               char buf[4096];
                va_list args;
+
                va_start(args, format);
-               vfprintf(out, format, args);
+               vsnprintf(buf, sizeof(buf), format, args);
                va_end(args);
+               fprintf(out, "%s\n", buf);
        }
 }
 
index 391da38e0016620f8dae053441f143df2525e83f..eb845ffbc89736e10de09442c4c30165723a0d6f 100644 (file)
@@ -82,10 +82,13 @@ static bool keyset_kskonly = false;
 static void
 report(const char *format, ...) {
        if (!quiet) {
+               char buf[4096];
                va_list args;
+
                va_start(args, format);
-               vfprintf(stdout, format, args);
+               vsnprintf(buf, sizeof(buf), format, args);
                va_end(args);
+               fprintf(stdout, "%s\n", buf);
        }
 }