]> git.ipfire.org Git - thirdparty/krb5.git/commitdiff
Fix unlikely leak in sendto_kdc
authorGreg Hudson <ghudson@mit.edu>
Wed, 29 Jun 2016 02:10:35 +0000 (22:10 -0400)
committerTom Yu <tlyu@mit.edu>
Fri, 2 Sep 2016 22:30:08 +0000 (18:30 -0400)
If a TCP connection is killed after it allocates the buffer (so is no
longer in READING state), free the buffer during cleanup.

(cherry picked from commit 6895dc9f204520e7f4da8da879cc67c149bc4e6b)

ticket: 8444
version_fixed: 1.13.7

src/lib/krb5/os/sendto_kdc.c

index 3b3b438ce6d89199dc0facf99b703449dc54ab2b..9c54d9948e5c7c840ad528022102963ed11e5e1d 100644 (file)
@@ -1512,7 +1512,7 @@ cleanup:
             closesocket(state->fd);
             free_http_tls_data(context, state);
         }
-        if (state->state == READING && state->in.buf != udpbuf)
+        if (state->in.buf != udpbuf)
             free(state->in.buf);
         if (callback_info) {
             callback_info->pfn_cleanup(callback_info->data,