]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
close connections
authorPhilip Jenvey <pjenvey@underboss.org>
Tue, 21 Jul 2009 21:07:04 +0000 (21:07 +0000)
committerPhilip Jenvey <pjenvey@underboss.org>
Tue, 21 Jul 2009 21:07:04 +0000 (21:07 +0000)
lib/sqlalchemy/test/testing.py
test/engine/test_transaction.py

index cdc6c050925fcf710c05f74f7b6464a57fe9f3b0..4a265fbec6010bd1479cef26ba46e8a5d00fb609 100644 (file)
@@ -281,9 +281,10 @@ def _server_version(bind=None):
         bind = config.db
     
     # force metadata to be retrieved
-    bind.connect()
-    
-    return getattr(bind.dialect, 'server_version_info', ())
+    conn = bind.connect()
+    version = getattr(bind.dialect, 'server_version_info', ())
+    conn.close()
+    return version
 
 def skip_if(predicate, reason=None):
     """Skip a test if predicate is true."""
index f34418665561d44eb404fbbde4a4dbb5e82b625a..4ac0e6134dbc6c308d4a9ff54e32ede94659aa5a 100644 (file)
@@ -20,7 +20,8 @@ class TransactionTest(TestBase):
         users.create(testing.db)
 
     def teardown(self):
-        testing.db.connect().execute(users.delete())
+        testing.db.connect().execute(users.delete()).close()
+
     @classmethod
     def teardown_class(cls):
         users.drop(testing.db)
@@ -383,7 +384,7 @@ class ExplicitAutoCommitTest(TestBase):
         testing.db.execute("create function insert_foo(varchar) returns integer as 'insert into foo(data) values ($1);select 1;' language sql")
 
     def teardown(self):
-        foo.delete().execute()
+        foo.delete().execute().close()
 
     @classmethod
     def teardown_class(cls):
@@ -456,8 +457,10 @@ class TLTransactionTest(TestBase):
             test_needs_acid=True,
         )
         users.create(tlengine)
+
     def teardown(self):
-        tlengine.execute(users.delete())
+        tlengine.execute(users.delete()).close()
+
     @classmethod
     def teardown_class(cls):
         users.drop(tlengine)
@@ -723,8 +726,10 @@ class ForUpdateTest(TestBase):
             test_needs_acid=True,
         )
         counters.create(testing.db)
+
     def teardown(self):
-        testing.db.connect().execute(counters.delete())
+        testing.db.connect().execute(counters.delete()).close()
+
     @classmethod
     def teardown_class(cls):
         counters.drop(testing.db)