]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
scsi: megaraid_mbox: Avoid double kfree()
authorArnd Bergmann <arnd@arndb.de>
Mon, 1 Jun 2026 21:02:04 +0000 (23:02 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 2 Jun 2026 01:55:19 +0000 (21:55 -0400)
Smatch found a double-free after my recent change:

drivers/scsi/megaraid/megaraid_mbox.c:3474 megaraid_cmm_register()
error: double free of 'adp' (line 3468)

Since the object is no longer allocated in megaraid_cmm_register(),
remove the kfree() as well.

Fixes: c1f7275b613b ("scsi: megaraid_mbox: Reduce stack usage in megaraid_cmm_register()")
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://patch.msgid.link/20260601210216.846809-1-arnd@kernel.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/megaraid/megaraid_mm.c

index 60db48dc8f3a4935e65f9ad8de0af72eb0c8ba41..e572665903d2c2a19a404bc436b6a824aa8391a9 100644 (file)
@@ -998,8 +998,6 @@ memalloc_error:
 
        dma_pool_destroy(adapter->pthru_dma_pool);
 
-       kfree(adapter);
-
        return rval;
 }