smbd: Remove a "!" from an if-condition for easier readability

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13215

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 03f65a7cdc91091a171269cfebc9916f2f678388)

diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c
index 900029d2a96d6ed89e288594703f41a1c20df978..e3e51996096b1c5fcf4445b64c55124c533f7808 100644 (file)
--- a/source3/smbd/smb2_server.c
+++ b/source3/smbd/smb2_server.c
@@ -2214,11 +2214,11 @@ static NTSTATUS smbd_smb2_request_dispatch_update_counts(
                cmp *= -1;
        }
 
-       if (!(flags & SMB2_HDR_FLAG_REPLAY_OPERATION)) {
-               if (cmp == 0) {
+       if (flags & SMB2_HDR_FLAG_REPLAY_OPERATION) {
+               if (cmp == 0 && op->pre_request_count == 0) {
                        op->request_count += 1;
                        req->request_counters_updated = true;
-               } else if (cmp > 0) {
+               } else if (cmp > 0 && op->pre_request_count == 0) {
                        op->pre_request_count += op->request_count;
                        op->request_count = 1;
                        op->global->channel_sequence = channel_sequence;
@@ -2228,10 +2228,10 @@ static NTSTATUS smbd_smb2_request_dispatch_update_counts(
                        return NT_STATUS_FILE_NOT_AVAILABLE;
                }
        } else {
-               if (cmp == 0 && op->pre_request_count == 0) {
+               if (cmp == 0) {
                        op->request_count += 1;
                        req->request_counters_updated = true;
-               } else if (cmp > 0 && op->pre_request_count == 0) {
+               } else if (cmp > 0) {
                        op->pre_request_count += op->request_count;
                        op->request_count = 1;
                        op->global->channel_sequence = channel_sequence;