]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
[PATCH] drm missing memset can crash X server..
authorairlied@linux.ie <airlied@linux.ie>
Sun, 13 Mar 2005 05:38:27 +0000 (21:38 -0800)
committerGreg KH <gregkh@suse.de>
Thu, 12 May 2005 17:00:08 +0000 (10:00 -0700)
Egbert Eich reported a bug 2673 on bugs.freedesktop.org and tracked it
down to a missing memset in the setversion ioctl, this causes X server
crashes...

From: Egbert Eich <eich@pdx.freedesktop.org>
Signed-off-by: Dave Airlie <airlied@linux.ie>
Signed-off-by: Chris Wright <chrisw@osdl.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/char/drm/drm_ioctl.c

index 6168509742948a03901193b18d73f764f82d7ad5..7621b35694dbd225f779547fff0fb27704dc386d 100644 (file)
@@ -326,6 +326,8 @@ int drm_setversion(DRM_IOCTL_ARGS)
 
        DRM_COPY_FROM_USER_IOCTL(sv, argp, sizeof(sv));
 
+       memset(&version, 0, sizeof(version));
+
        dev->driver->version(&version);
        retv.drm_di_major = DRM_IF_MAJOR;
        retv.drm_di_minor = DRM_IF_MINOR;