hwmon: (emc2305) fix double put in emc2305_probe_childs_from_dt

[ Upstream commit 541dfb49dcb80c2509e030842de77adfb77820f5 ]

./drivers/hwmon/emc2305.c:597:4-15: ERROR: probable double put

Device node iterators put the previous value of the index variable, so an
explicit put causes a double put.

Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
Link: https://lore.kernel.org/r/tencent_CD373F952BE48697C949E39CB5EB77841D06@qq.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/hwmon/emc2305.c b/drivers/hwmon/emc2305.c
index 84cb9b72cb6c2b153dcf8743dd8978eb0a9b5c0a..ceae96c07ac45baa11229d84c75cd4473ad3adfe 100644 (file)
--- a/drivers/hwmon/emc2305.c
+++ b/drivers/hwmon/emc2305.c
@@ -593,10 +593,8 @@ static int emc2305_probe_childs_from_dt(struct device *dev)
        for_each_child_of_node(dev->of_node, child) {
                if (of_property_present(child, "reg")) {
                        ret = emc2305_of_parse_pwm_child(dev, child, data);
-                       if (ret) {
-                               of_node_put(child);
+                       if (ret)
                                continue;
-                       }
                        count++;
                }
        }