]> git.ipfire.org Git - thirdparty/dhcpcd.git/commitdiff
Clarify the problem of identifying a bootp vs dhcp message.
authorRoy Marples <roy@marples.name>
Sat, 17 Jan 2015 00:32:18 +0000 (00:32 +0000)
committerRoy Marples <roy@marples.name>
Sat, 17 Jan 2015 00:32:18 +0000 (00:32 +0000)
dhcp.c

diff --git a/dhcp.c b/dhcp.c
index 91a9ce9dc488c4382e92821a9b5080a523e9c21d..23bdaf19cda1613a45af2d30a65ea6cd08307b58 100644 (file)
--- a/dhcp.c
+++ b/dhcp.c
@@ -2574,7 +2574,10 @@ dhcp_handledhcp(struct interface *iface, struct dhcp_message **dhcpp,
                    get_option_uint8(iface->ctx, &tmp, dhcp, (uint8_t)i) != 0)
                {
                        /* If we are bootp, then ignore the need for serverid.
-                        * To ignore bootp, require dhcp_message_type. */
+                        * To ignore bootp, require dhcp_message_type.
+                        * However, nothing really stops bootp from providing
+                        * DHCP style options as well so the above isn't
+                        * always true. */
                        if (type == 0 && i == DHO_SERVERID)
                                continue;
                        log_dhcp(LOG_WARNING, "reject DHCP", iface, dhcp, from);