]> git.ipfire.org Git - thirdparty/openssh-portable.git/commitdiff
upstream: Plug potential mem leak in process_put.
authordtucker@openbsd.org <dtucker@openbsd.org>
Wed, 29 Mar 2023 00:59:08 +0000 (00:59 +0000)
committerDarren Tucker <dtucker@dtucker.net>
Wed, 29 Mar 2023 01:22:33 +0000 (12:22 +1100)
It allocates abs_dst inside a loop but only frees it on exit, so free
inside the loop if necessary.  Coverity CID 291837, ok djm@

OpenBSD-Commit-ID: a01616503a185519b16f00dde25d34ceaf4ae1a3

sftp.c

diff --git a/sftp.c b/sftp.c
index 6c5aab7a554dc147a132528ab8d4fd62338ddc1a..07b46c7f7cf26c11f5ef368bc8a2859b28dd4e31 100644 (file)
--- a/sftp.c
+++ b/sftp.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: sftp.c,v 1.230 2023/03/28 07:44:32 dtucker Exp $ */
+/* $OpenBSD: sftp.c,v 1.231 2023/03/29 00:59:08 dtucker Exp $ */
 /*
  * Copyright (c) 2001-2004 Damien Miller <djm@openbsd.org>
  *
@@ -769,6 +769,8 @@ process_put(struct sftp_conn *conn, const char *src, const char *dst,
                        goto out;
                }
 
+               free(abs_dst);
+               abs_dst = NULL;
                if (g.gl_matchc == 1 && tmp_dst) {
                        /* If directory specified, append filename */
                        if (dst_is_dir)