re PR tree-optimization/30132 (ICE in find_lattice_value, at tree-complex.c:133)

2008-01-09  Richard Guenther  <rguenther@suse.de>
	Andrew Pinski  <andrew_pinski@playstation.sony.com>

        PR middle-end/30132
	* gimplify.c (gimplify_cond_expr): Do not create an addressable
	temporary if an rvalue is ok or an lvalue is not required.

	* gcc.c-torture/compile/pr30132.c: New testcase.

Co-Authored-By: Andrew Pinski <andrew_pinski@playstation.sony.com>
From-SVN: r131430

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index acfca73d9e810cd62f758ef04ddb4ef1e85ef684..bfdeb6571c0c2f7a2406a10622fbc8e86d81f5a1 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2008-01-09  Richard Guenther  <rguenther@suse.de>
+       Andrew Pinski  <andrew_pinski@playstation.sony.com>
+
+       PR middle-end/30132
+       * gimplify.c (gimplify_cond_expr): Do not create an addressable
+       temporary if an rvalue is ok or an lvalue is not required.
+
 2008-01-09  Richard Guenther  <rguenther@suse.de>
 
        PR middle-end/34458

diff --git a/gcc/gimplify.c b/gcc/gimplify.c
index dd832228f0aa863397ce8d57139a69956d252ddb..52547415c0ac4bcb8ae19724d70d35ec8b8b2bba 100644 (file)
--- a/gcc/gimplify.c
+++ b/gcc/gimplify.c
@@ -2633,7 +2633,11 @@ gimplify_cond_expr (tree *expr_p, tree *pre_p, fallback_t fallback)
     {
       tree result;
 
-      if ((fallback & fb_lvalue) == 0)
+      /* If an rvalue is ok or we do not require an lvalue, avoid creating
+        an addressable temporary.  */
+      if (((fallback & fb_rvalue)
+          || !(fallback & fb_lvalue))
+         && !TREE_ADDRESSABLE (type))
        {
          if (gimplify_ctxp->allow_rhs_cond_expr
              /* If either branch has side effects or could trap, it can't be

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 78f54391a06f611cc19e988dcb5d1aedc1b4d2dd..3201f9e505132ce31e9c01cc12399db08de4e7dc 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2008-01-09  Richard Guenther  <rguenther@suse.de>
+       Andrew Pinski  <andrew_pinski@playstation.sony.com>
+
+       PR middle-end/30132
+       * gcc.c-torture/compile/pr30132.c: New testcase.
+
 2008-01-09  Richard Guenther  <rguenther@suse.de>
 
        PR middle-end/34458

diff --git a/gcc/testsuite/gcc.c-torture/compile/pr30132.c b/gcc/testsuite/gcc.c-torture/compile/pr30132.c
new file mode 100644 (file)
index 0000000..adffae7
--- /dev/null
+++ b/gcc/testsuite/gcc.c-torture/compile/pr30132.c
@@ -0,0 +1,5 @@
+double testit(double _Complex* t)
+{
+  return *t==0.0?0.0:-*t;
+}
+