]> git.ipfire.org Git - thirdparty/ipxe.git/commitdiff
[forcedeth] Never change the NVREG_TRANSMITPOLL_MAC_ADDR_REV flag
authorMichael Brown <mcb30@ipxe.org>
Tue, 29 Mar 2011 23:33:48 +0000 (00:33 +0100)
committerMichael Brown <mcb30@ipxe.org>
Tue, 29 Mar 2011 23:34:09 +0000 (00:34 +0100)
iPXE operates the forcedeth NIC in promiscuous mode, and never changes
the unicast MAC address filter registers.  We should not therefore set
the flag indicating (to other drivers loaded later) that the MAC
address order has already been corrected.

Reported-by: Tal Aloni <tal.aloni.il@gmail.com>
Tested-by: Tal Aloni <tal.aloni.il@gmail.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
src/drivers/net/forcedeth.c

index bb3d68447554cf5608fd8f102f7ac63ec2676cf3..c34a42961479c81753c7aef9cb1840592b1913bc 100644 (file)
@@ -1098,11 +1098,6 @@ nv_setup_mac_addr ( struct forcedeth_private *priv )
                dev->hw_addr[3] = ( orig_mac[0] >> 16 ) & 0xff;
                dev->hw_addr[4] = ( orig_mac[0] >> 8 ) & 0xff;
                dev->hw_addr[5] = ( orig_mac[0] >> 0 ) & 0xff;
-
-               writel ( txreg | NVREG_TRANSMITPOLL_MAC_ADDR_REV,
-                        ioaddr + NvRegTransmitPoll );
-
-               DBG ( "set workaround bit for reversed mac addr\n" );
        }
 
        if ( ! is_valid_ether_addr ( dev->hw_addr ) )