]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Jump to cleanup label on umount failure
authorJim Fehlig <jfehlig@suse.com>
Mon, 6 Feb 2023 17:40:12 +0000 (10:40 -0700)
committerJim Fehlig <jfehlig@suse.com>
Tue, 7 Feb 2023 17:52:35 +0000 (10:52 -0700)
Similar to other error paths in qemuDomainUnshareNamespace(), jump to
the cleanup label on umount error instead of directly returning -1.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_namespace.c

index 5769a4dfe0f6ef5ee34ec902ad3f4432574c6470..833313d5a636f1ea207b13c8a3be30e82c452197 100644 (file)
@@ -779,7 +779,7 @@ qemuDomainUnshareNamespace(virQEMUDriverConfig *cfg,
 #if defined(__linux__)
     if (umount("/dev") < 0) {
         virReportSystemError(errno, "%s", _("failed to umount devfs on /dev"));
-        return -1;
+        goto cleanup;
     }
 #endif /* !defined(__linux__) */