]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
scsi: hisi_sas: Fix the risk of overflow in bitwise logical operations
authorYihang Li <liyihang9@huawei.com>
Thu, 5 Mar 2026 06:47:00 +0000 (14:47 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 7 Mar 2026 16:20:30 +0000 (11:20 -0500)
Fix a few constants defined via macros that had overflow risks.

Signed-off-by: Yihang Li <liyihang9@huawei.com>
Link: https://patch.msgid.link/20260305064700.116033-3-liyihang9@huawei.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c

index 6a841d53bb1080be8f9099e6af3292882b10009f..ba9d6877483ad6088cbf3c658daeef922ddf2e77 100644 (file)
 #define CMPLT_HDR_IPTT_OFF             0
 #define CMPLT_HDR_IPTT_MSK             (0xffff << CMPLT_HDR_IPTT_OFF)
 #define CMPLT_HDR_DEV_ID_OFF           16
-#define CMPLT_HDR_DEV_ID_MSK           (0xffff << CMPLT_HDR_DEV_ID_OFF)
+#define CMPLT_HDR_DEV_ID_MSK           (0xffffU << CMPLT_HDR_DEV_ID_OFF)
 /* dw3 */
 #define SATA_DISK_IN_ERROR_STATUS_OFF  8
 #define SATA_DISK_IN_ERROR_STATUS_MSK  (0x1 << SATA_DISK_IN_ERROR_STATUS_OFF)
 #define FIS_ATA_STATUS_ERR_OFF         18
 #define FIS_ATA_STATUS_ERR_MSK         (0x1 << FIS_ATA_STATUS_ERR_OFF)
 #define FIS_TYPE_SDB_OFF               31
-#define FIS_TYPE_SDB_MSK               (0x1 << FIS_TYPE_SDB_OFF)
+#define FIS_TYPE_SDB_MSK               (0x1U << FIS_TYPE_SDB_OFF)
 
 /* ITCT header */
 /* qw0 */