don't return nonsense when toString() is called on an unset or invalid ComboAddress

diff --git a/pdns/iputils.hh b/pdns/iputils.hh
index e15d26a9547295e8627a4e27d606b93d9e147c6c..50455066bf97720fc1bccdbc3e068e9a16ad467a 100644 (file)
--- a/pdns/iputils.hh
+++ b/pdns/iputils.hh
@@ -211,9 +211,10 @@ union ComboAddress {
   string toString() const
   {
     char host[1024];
-    getnameinfo((struct sockaddr*) this, getSocklen(), host, sizeof(host),0, 0, NI_NUMERICHOST);
-      
-    return host;
+    if(sin4.sin_family && !getnameinfo((struct sockaddr*) this, getSocklen(), host, sizeof(host),0, 0, NI_NUMERICHOST))
+      return host;
+    else
+      return "invalid";
   }
 
   string toStringWithPort() const