2873. [bug] Canceling a dynamic update via the dns/client module

			could trigger an assertion failure. [RT #21133]

diff --git a/CHANGES b/CHANGES
index 30408ea6eb0593395604671166682aac1978b73a..cce109dae0bfc184df1abc44d468c7332ed6ce4a 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,6 @@
+2873.  [bug]           Canceling a dynamic update via the dns/client module
+                       could trigger an assertion failure. [RT #21133]
+
 2872.  [bug]           Modify dns/client.c:dns_client_createx() to only
                        require one of IPv4 or IPv6 rather than both.
                        [RT #21122]

diff --git a/lib/dns/client.c b/lib/dns/client.c
index 025698746346e64d7809de314a98959b8a144f03..0e9d1d9e2b364b259e3fb18c21133c92ae580a1d 100644 (file)
--- a/lib/dns/client.c
+++ b/lib/dns/client.c
@@ -14,7 +14,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: client.c,v 1.8 2010/04/13 23:50:58 tbox Exp $ */
+/* $Id: client.c,v 1.9 2010/04/14 22:08:47 jinmei Exp $ */
 
 #include <config.h>
 
@@ -2808,9 +2808,9 @@ dns_client_cancelupdate(dns_clientupdatetrans_t *trans) {
                if (uctx->soareq != NULL)
                        dns_request_cancel(uctx->soareq);
                if (uctx->restrans != NULL)
-                       dns_client_cancelresolve(&uctx->restrans);
+                       dns_client_cancelresolve(uctx->restrans);
                if (uctx->restrans2 != NULL)
-                       dns_client_cancelresolve(&uctx->restrans2);
+                       dns_client_cancelresolve(uctx->restrans2);
        }
 
        UNLOCK(&uctx->lock);