]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mm/damon/tests/core-kunit: handle alloc failures in damon_test_ops_registration()
authorSeongJae Park <sj@kernel.org>
Sat, 1 Nov 2025 18:20:03 +0000 (11:20 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 11 Jan 2026 14:22:32 +0000 (15:22 +0100)
commit 4f835f4e8c863985f15abd69db033c2f66546094 upstream.

damon_test_ops_registration() is assuming all dynamic memory allocation in
it will succeed.  Those are indeed likely in the real use cases since
those allocations are too small to fail, but theoretically those could
fail.  In the case, inappropriate memory access can happen.  Fix it by
appropriately cleanup pre-allocated memory and skip the execution of the
remaining tests in the failure cases.

Link: https://lkml.kernel.org/r/20251101182021.74868-10-sj@kernel.org
Fixes: 4f540f5ab4f2 ("mm/damon/core-test: add a kunit test case for ops registration")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org> [5.19+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mm/damon/core-test.h

index e71d50f0a2dfbe63e480b2e22a83d779f21b9644..d714fe76e35db84f009fc912a7e116352b0cf6b2 100644 (file)
@@ -308,6 +308,9 @@ static void damon_test_ops_registration(struct kunit *test)
        struct damon_ctx *c = damon_new_ctx();
        struct damon_operations ops, bak;
 
+       if (!c)
+               kunit_skip(test, "ctx alloc fail");
+
        /* DAMON_OPS_{V,P}ADDR are registered on subsys_initcall */
        KUNIT_EXPECT_EQ(test, damon_select_ops(c, DAMON_OPS_VADDR), 0);
        KUNIT_EXPECT_EQ(test, damon_select_ops(c, DAMON_OPS_PADDR), 0);