flock: zero timeout is valid

This patch reverts Sami's "timeout cannot be zero", introduced
in commit 605325b23b36238c8f3ae165e37cab9064553cf7.

The --timeout 0 has been originally interpreted as --nonblock. The
patch also add hint about this behavior to the man page.

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1149974
Signed-off-by: Karel Zak <kzak@redhat.com>

diff --git a/sys-utils/flock.1 b/sys-utils/flock.1
index 276d72633fcad48f746fae39df2e45bc711377ad..f6904019083993ee74446112ef675c4ed5867bad 100644 (file)
--- a/sys-utils/flock.1
+++ b/sys-utils/flock.1
@@ -103,7 +103,9 @@ Fail if the lock cannot be acquired within
 Decimal fractional values are allowed.
 See the
 .B \-E
-option for the exit code used.
+option for the exit code used. The zero number of
+.IR seconds
+is interpreted as \fB\-\-nonblock\fR.
 .TP
 .BR \-V , " \-\-version"
 Display version information and exit.

diff --git a/sys-utils/flock.c b/sys-utils/flock.c
index 62c6f7c7cef92a361dbb79d5cbfd0a0632fc3dfb..2550a5be7504ee699e05e68f4a6b3eadc715fa4d 100644 (file)
--- a/sys-utils/flock.c
+++ b/sys-utils/flock.c
@@ -175,8 +175,6 @@ int main(int argc, char *argv[])
                        have_timeout = 1;
                        strtotimeval_or_err(optarg, &timeout.it_value,
                                _("invalid timeout value"));
-                       if (timeout.it_value.tv_sec + timeout.it_value.tv_usec == 0)
-                               errx(EX_USAGE, _("timeout cannot be zero"));
                        break;
                case 'E':
                        conflict_exit_code = strtos32_or_err(optarg,