]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Get default hugepage size only if needed
authorMichal Privoznik <mprivozn@redhat.com>
Mon, 27 May 2019 09:07:12 +0000 (11:07 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 27 May 2019 12:51:39 +0000 (14:51 +0200)
Fixes: 6864d8f740e2502dc7625bdf18ffde4465b14f69
Hugepages don't work in session mode but when building memory
part of command line we query for the default size anyway. This
breaks creating domains under session daemon. Query the page size
only if it's clear we need hugepages.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/qemu/qemu_command.c

index 73f570c41962b0733b05ac9047eed3b0a4f47e9a..5bf6c704e073fbc1e0ca93bc337064f6718aa3e1 100644 (file)
@@ -3573,7 +3573,7 @@ qemuBuildMemoryBackendProps(virJSONValuePtr *backendProps,
         pagesize = 0;
         needHugepage = false;
         useHugepage = false;
-    } else if (pagesize == 0) {
+    } else if (useHugepage && pagesize == 0) {
         if (qemuBuildMemoryGetDefaultPagesize(cfg, &pagesize) < 0)
             goto cleanup;
     }