]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
memory: emif: check the pointer temp in get_device_details()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 25 Feb 2022 13:25:52 +0000 (05:25 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Apr 2022 07:08:15 +0000 (09:08 +0200)
[ Upstream commit 5b5ab1bfa1898c6d52936a57c25c5ceba2cb2f87 ]

The pointer temp is allocated by devm_kzalloc(), so it should be
checked for error handling.

Fixes: 7ec944538dde ("memory: emif: add basic infrastructure for EMIF driver")
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Link: https://lore.kernel.org/r/20220225132552.27894-1-baijiaju1990@gmail.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/memory/emif.c

index ed6c5fcb136f0d0a4b23101eeb957767e3c89431..9f293b931144ed39aa8de06ac2af404a598ae8e2 100644 (file)
@@ -1425,7 +1425,7 @@ static struct emif_data *__init_or_module get_device_details(
        temp    = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL);
        dev_info = devm_kzalloc(dev, sizeof(*dev_info), GFP_KERNEL);
 
-       if (!emif || !pd || !dev_info) {
+       if (!emif || !temp || !dev_info) {
                dev_err(dev, "%s:%d: allocation error\n", __func__, __LINE__);
                goto error;
        }