]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
gpib: fmh_gpib: Fix the *allocate_private retval check
authorDominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Fri, 16 Jan 2026 17:48:14 +0000 (17:48 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Jan 2026 15:04:07 +0000 (16:04 +0100)
Change

if (retval < 0)
        return retval;

into

if (retval)
        return retval;

as it is more fitting in this case.

Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
Link: https://patch.msgid.link/20260116174647.317256-12-dominik.karol.piatkowski@protonmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpib/fmh_gpib/fmh_gpib.c

index b8d955f124bd5f946a83da9b7c48ab3f8e2d72cb..d82ec06b30858ac3f0f8a812a15a7f2e75c82b76 100644 (file)
@@ -1285,7 +1285,7 @@ static int fmh_gpib_generic_attach(struct gpib_board *board)
        board->status = 0;
 
        retval = fmh_gpib_allocate_private(board);
-       if (retval < 0)
+       if (retval)
                return retval;
        e_priv = board->private_data;
        nec_priv = &e_priv->nec7210_priv;