]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
platform/x86: quickstart: Use devm_mutex_init()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 7 Sep 2025 13:32:26 +0000 (15:32 +0200)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Mon, 8 Sep 2025 10:13:41 +0000 (13:13 +0300)
Use devm_mutex_init() instead of hand-writing it.

This saves some LoC, improves readability and saves some space in the
generated .o file.

Before:
======
   text    data     bss     dec     hex filename
   7607    2616      64   10287    282f drivers/platform/x86/quickstart.o

After:
=====
   text    data     bss     dec     hex filename
   7301    2544      64    9909    26b5 drivers/platform/x86/quickstart.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/530b930c981c436c172c0308b348d4ae4ef72800.1757251867.git.christophe.jaillet@wanadoo.fr
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/quickstart.c

index c332c7cdaff54eb7cf9e9df26ad24dc1f3f8ad12..acb58518be37714d843f2ba37b5562e2fe3fda67 100644 (file)
@@ -154,13 +154,6 @@ static void quickstart_notify_remove(void *context)
        acpi_remove_notify_handler(handle, ACPI_DEVICE_NOTIFY, quickstart_notify);
 }
 
-static void quickstart_mutex_destroy(void *data)
-{
-       struct mutex *lock = data;
-
-       mutex_destroy(lock);
-}
-
 static int quickstart_probe(struct platform_device *pdev)
 {
        struct quickstart_data *data;
@@ -179,8 +172,7 @@ static int quickstart_probe(struct platform_device *pdev)
        data->dev = &pdev->dev;
        dev_set_drvdata(&pdev->dev, data);
 
-       mutex_init(&data->input_lock);
-       ret = devm_add_action_or_reset(&pdev->dev, quickstart_mutex_destroy, &data->input_lock);
+       ret = devm_mutex_init(&pdev->dev, &data->input_lock);
        if (ret < 0)
                return ret;