]> git.ipfire.org Git - thirdparty/libcgroup.git/commitdiff
daemon/cgrulesengd: check the bytes read in cgre_receive_unix_domain_msg()
authorKamalesh Babulal <kamalesh.babulal@oracle.com>
Wed, 10 Aug 2022 17:10:54 +0000 (11:10 -0600)
committerTom Hromatka <tom.hromatka@oracle.com>
Wed, 10 Aug 2022 17:12:02 +0000 (11:12 -0600)
Fix ignoring the number of bytes read, warning reported by Coverity
tool:

CID 258286 (#1 of 1): Ignoring number of bytes read (CHECKED_RETURN).
check_return: read(int, void *, size_t) returns the number of bytes
read, but it is ignored.

In cgre_receive_unix_domain_msg(), the number of bytes read() is
ignored, while reading from the flag value of the pid. Coverity warns on
not checking the number of bytes read, fix it.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
(cherry picked from commit ed283eab173addd3b5c2dd666de8f3086125e106)

src/daemon/cgrulesengd.c

index d76f13faaa1fd114a5bf4072378f81485814bc52..f597d25ee7fd1cfe0e403ef54b2ee819a34c11ab 100644 (file)
@@ -618,7 +618,8 @@ static void cgre_receive_unix_domain_msg(int sk_unix)
                                strerror(errno));
                return;
        }
-       if (read(fd_client, &pid, sizeof(pid)) < 0) {
+       ret_len = read(fd_client, &pid, sizeof(pid));
+       if (ret_len != sizeof(pid)) {
                flog(LOG_WARNING, "Warning: 'read' command error: %s\n",
                                strerror(errno));
                goto close;