]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: codecs: pcm512x: only print info once on no sclk
authorChristian Hewitt <christianshewitt@gmail.com>
Thu, 25 Jun 2026 12:28:11 +0000 (12:28 +0000)
committerMark Brown <broonie@kernel.org>
Thu, 25 Jun 2026 13:35:50 +0000 (14:35 +0100)
If sclk is not provided the driver falls back to using bclk and prints
an info message in the system log. Under normal operations the message
is repeated many times:

[   17.929576] pcm512x 0-004c: No SCLK, using BCLK: -2
[   17.949172] pcm512x 0-004c: No SCLK, using BCLK: -2
[   17.953029] pcm512x 0-004c: No SCLK, using BCLK: -2
[   17.965059] pcm512x 0-004c: No SCLK, using BCLK: -2
[   82.592980] pcm512x 0-004c: No SCLK, using BCLK: -2
[   82.866293] pcm512x 0-004c: No SCLK, using BCLK: -2

Switch from dev_info to dev_info_once to reduce log noise.

Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
Link: https://patch.msgid.link/20260625122811.4056274-1-christianshewitt@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/pcm512x.c

index fdef98ce52f19b5c8c92470c3c5fa8e841d666db..fe3b5011fa1678539d814d2d7db461d8555fa3b3 100644 (file)
@@ -633,7 +633,7 @@ static int pcm512x_dai_startup_slave(struct snd_pcm_substream *substream,
        struct regmap *regmap = pcm512x->regmap;
 
        if (IS_ERR(pcm512x->sclk)) {
-               dev_info(dev, "No SCLK, using BCLK: %ld\n",
+               dev_info_once(dev, "No SCLK, using BCLK: %ld\n",
                         PTR_ERR(pcm512x->sclk));
 
                /* Disable reporting of missing SCLK as an error */