]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
accel/habanalabs: return ENOMEM if less than requested pages were pinned
authorTomer Tayar <tomer.tayar@intel.com>
Sun, 26 May 2024 13:32:32 +0000 (16:32 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Nov 2025 20:34:30 +0000 (15:34 -0500)
[ Upstream commit 9f5067531c9b79318c4e48a933cb2694f53f3de2 ]

EFAULT is currently returned if less than requested user pages are
pinned. This value means a "bad address" which might be confusing to
the user, as the address of the given user memory is not necessarily
"bad".

Modify the return value to ENOMEM, as "out of memory" is more suitable
in this case.

Signed-off-by: Tomer Tayar <tomer.tayar@intel.com>
Reviewed-by: Koby Elbaz <koby.elbaz@intel.com>
Signed-off-by: Koby Elbaz <koby.elbaz@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/accel/habanalabs/common/memory.c

index 11c55fd76db58d84861226c155b73ac3c825b7c0..0f27fd841f3abf4e97f1564429bc592e17bd738d 100644 (file)
@@ -2332,7 +2332,7 @@ static int get_user_memory(struct hl_device *hdev, u64 addr, u64 size,
                if (rc < 0)
                        goto destroy_pages;
                npages = rc;
-               rc = -EFAULT;
+               rc = -ENOMEM;
                goto put_pages;
        }
        userptr->npages = npages;