]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
devlink: Add error print when unknown values specified
authorParav Pandit <parav@nvidia.com>
Mon, 1 Mar 2021 10:56:54 +0000 (12:56 +0200)
committerDavid Ahern <dsahern@kernel.org>
Wed, 3 Mar 2021 04:00:16 +0000 (04:00 +0000)
When user specifies either unknown flavour or unknown state during
devlink port commands, return appropriate error message.

Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: David Ahern <dsahern@kernel.org>
devlink/devlink.c

index eaac1806d6865beec676821f8d66cea0cb562b50..16eca4f9eed926716c09fc6bff4e7246128002ad 100644 (file)
@@ -1372,8 +1372,10 @@ static int port_flavour_parse(const char *flavour, uint16_t *value)
        int num;
 
        num = str_map_lookup_str(port_flavour_map, flavour);
-       if (num < 0)
+       if (num < 0) {
+               invarg("unknown flavour", flavour);
                return num;
+       }
        *value = num;
        return 0;
 }
@@ -1383,8 +1385,10 @@ static int port_fn_state_parse(const char *statestr, uint8_t *state)
        int num;
 
        num = str_map_lookup_str(port_fn_state_map, statestr);
-       if (num < 0)
+       if (num < 0) {
+               invarg("unknown state", statestr);
                return num;
+       }
        *state = num;
        return 0;
 }