]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/panthor: unlock on error in panthor_ioctl_bo_create()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 18 Dec 2025 07:48:22 +0000 (10:48 +0300)
committerBoris Brezillon <boris.brezillon@collabora.com>
Thu, 18 Dec 2025 10:08:21 +0000 (11:08 +0100)
Call drm_dev_exit() before returning -EINVAL.

Fixes: cd2c9c3015e6 ("drm/panthor: Add flag to map GEM object Write-Back Cacheable")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Link: https://patch.msgid.link/aUOxxvXXtHHfFCcg@stanley.mountain
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
drivers/gpu/drm/panthor/panthor_drv.c

index 98d4e8d867ed46915ac4a069fe8ca222b34db5d4..165dddfde6ca8b45a81046e86c9e30baaef0865a 100644 (file)
@@ -923,8 +923,10 @@ static int panthor_ioctl_bo_create(struct drm_device *ddev, void *data,
        }
 
        if ((args->flags & DRM_PANTHOR_BO_NO_MMAP) &&
-           (args->flags & DRM_PANTHOR_BO_WB_MMAP))
-               return -EINVAL;
+           (args->flags & DRM_PANTHOR_BO_WB_MMAP)) {
+               ret = -EINVAL;
+               goto out_dev_exit;
+       }
 
        if (args->exclusive_vm_id) {
                vm = panthor_vm_pool_get_vm(pfile->vms, args->exclusive_vm_id);