]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:samr: Add missing NULL pointer check
authorAndreas Schneider <asn@samba.org>
Wed, 10 Jun 2020 15:35:55 +0000 (17:35 +0200)
committerIsaac Boukris <iboukris@sn-devel-184>
Tue, 16 Jun 2020 09:08:34 +0000 (09:08 +0000)
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Isaac Boukris <iboukris@samba.org>
source3/rpc_server/samr/srv_samr_chgpasswd.c

index 8bc7af09ee9a410f9b7b7cd5b3913ef891bbd64b..cb9837ecf01891fc87ee52fb4363f9de4fc9dc15 100644 (file)
@@ -638,6 +638,9 @@ the string %%u, and the given string %s does not.\n", passwordprogram ));
                                        chatsequence,
                                        "%n",
                                        newpass);
+       if (chatsequence == NULL) {
+               return false;
+       }
        return chat_with_program(passwordprogram,
                                pass,
                                chatsequence,