]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
regmap: Move selecting for REGMAP_MDIO and REGMAP_IRQ
authorAndrew Davis <afd@ti.com>
Fri, 16 May 2025 14:17:22 +0000 (09:17 -0500)
committerMark Brown <broonie@kernel.org>
Tue, 20 May 2025 09:25:08 +0000 (10:25 +0100)
If either REGMAP_IRQ or REGMAP_MDIO are set then REGMAP is also set.
This then enables the selecting of IRQ_DOMAIN or MDIO_BUS from REGMAP
based on the above two symbols respectively. This makes it very easy
to end up with "circular dependencies".

Instead select the IRQ_DOMAIN or MDIO_BUS from the symbols that make
use of them. This is almost equivalent to before but makes it less
likely to end up with false circular dependency detections.

Signed-off-by: Andrew Davis <afd@ti.com>
Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Closes: https://lore.kernel.org/r/bfe991fa-f54c-4d58-b2e0-34c4e4eb48f4@linaro.org/
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20250516141722.13772-1-afd@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/base/regmap/Kconfig

index b1affac70d5dcc290b9bf644bd138f7cbd79dbc0..ffb2ef488298191a9ec2eb55ac712409a1445230 100644 (file)
@@ -6,8 +6,6 @@
 config REGMAP
        bool
        default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SOUNDWIRE || REGMAP_SOUNDWIRE_MBQ || REGMAP_SCCB || REGMAP_I3C || REGMAP_SPI_AVMM || REGMAP_MDIO || REGMAP_FSI)
-       select IRQ_DOMAIN if REGMAP_IRQ
-       select MDIO_BUS if REGMAP_MDIO
        help
          Enable support for the Register Map (regmap) access API.
 
@@ -58,12 +56,14 @@ config REGMAP_W1
 
 config REGMAP_MDIO
        tristate
+       select MDIO_BUS
 
 config REGMAP_MMIO
        tristate
 
 config REGMAP_IRQ
        bool
+       select IRQ_DOMAIN
 
 config REGMAP_RAM
        tristate