]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ALSA: hda/cirrus_scodec_test: Fix incorrect setup of gpiochip
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Tue, 13 Jan 2026 13:09:54 +0000 (13:09 +0000)
committerTakashi Iwai <tiwai@suse.de>
Tue, 13 Jan 2026 13:13:59 +0000 (14:13 +0100)
Set gpiochip parent to the struct device of the dummy GPIO driver
so that the software node will be associated with the GPIO chip.

The recent commit e5d527be7e698 ("gpio: swnode: don't use the
swnode's name as the key for GPIO lookup") broke cirrus_scodec_test,
because the software node no longer gets associated with the GPIO
driver by name.

Instead, setting struct gpio_chip.parent to the owning struct device
will find the node using a normal fwnode lookup.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 2144833e7b414 ("ALSA: hda: cirrus_scodec: Add KUnit test")
Link: https://patch.msgid.link/20260113130954.574670-1-rf@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/hda/codecs/side-codecs/cirrus_scodec_test.c

index 3cca750857b68961115e1cde651dc5a6041b233b..159ac80a93144059f4a9b75060104f589158391a 100644 (file)
@@ -103,6 +103,7 @@ static int cirrus_scodec_test_gpio_probe(struct platform_device *pdev)
 
        /* GPIO core modifies our struct gpio_chip so use a copy */
        gpio_priv->chip = cirrus_scodec_test_gpio_chip;
+       gpio_priv->chip.parent = &pdev->dev;
        ret = devm_gpiochip_add_data(&pdev->dev, &gpio_priv->chip, gpio_priv);
        if (ret)
                return dev_err_probe(&pdev->dev, ret, "Failed to add gpiochip\n");