]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: renesas: rza1: Use new GPIO line value setter callbacks
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 11 Jun 2025 07:27:54 +0000 (09:27 +0200)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 13 Jun 2025 09:25:47 +0000 (11:25 +0200)
struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/20250611-gpiochip-set-rv-pinctrl-renesas-v1-3-ad169a794ef0@linaro.org
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
drivers/pinctrl/renesas/pinctrl-rza1.c

index b1058504e0bb3eb4dae8ac5b0eb848eeaeb907af..3d8492c917104afbf15c8f697ba4afabafa3a5cf 100644 (file)
@@ -830,12 +830,13 @@ static int rza1_gpio_get(struct gpio_chip *chip, unsigned int gpio)
        return rza1_pin_get(port, gpio);
 }
 
-static void rza1_gpio_set(struct gpio_chip *chip, unsigned int gpio,
-                         int value)
+static int rza1_gpio_set(struct gpio_chip *chip, unsigned int gpio, int value)
 {
        struct rza1_port *port = gpiochip_get_data(chip);
 
        rza1_pin_set(port, gpio, value);
+
+       return 0;
 }
 
 static const struct gpio_chip rza1_gpiochip_template = {
@@ -845,7 +846,7 @@ static const struct gpio_chip rza1_gpiochip_template = {
        .direction_input        = rza1_gpio_direction_input,
        .direction_output       = rza1_gpio_direction_output,
        .get                    = rza1_gpio_get,
-       .set                    = rza1_gpio_set,
+       .set_rv                 = rza1_gpio_set,
 };
 /* ----------------------------------------------------------------------------
  * pinctrl operations