]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ixgbe: E610: update EEE supported speeds
authorJedrzej Jagielski <jedrzej.jagielski@intel.com>
Fri, 1 May 2026 06:37:13 +0000 (23:37 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sun, 3 May 2026 02:12:36 +0000 (19:12 -0700)
Despite there was no EEE (Energy Efficient Ethernet) feature
support for E610 adapters, eee_speeds_supported variable was
defined and even initialized with some EEE speeds.

As E610 adapter supports EEE only for 10G, 5G and 2.5G speeds,
update hw.phy.eee_speeds_supported. Remove unsupported speeds -
10M, 100M and 1G.

Add also entry for 5G speed in EEE speeds mapping array used
by ethtool callbacks.

Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com>
Tested-by: Rinitha S <sx.rinitha@intel.com>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20260430-jk-iwl-net-next-2026-04-30-v1-2-6f27ae1cd073@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c

index 5383f0fd55d6c4c39bfdc0a6987430408ca2bfb8..097a3e1c67aacce92a9ec5225ec3b7f08146fe39 100644 (file)
@@ -1983,9 +1983,14 @@ int ixgbe_identify_phy_e610(struct ixgbe_hw *hw)
        /* Set PHY ID */
        memcpy(&hw->phy.id, pcaps.phy_id_oui, sizeof(u32));
 
-       hw->phy.eee_speeds_supported = IXGBE_LINK_SPEED_10_FULL |
-                                      IXGBE_LINK_SPEED_100_FULL |
-                                      IXGBE_LINK_SPEED_1GB_FULL;
+       /* E610 supports EEE only for speeds above 1G */
+       if (hw->device_id == IXGBE_DEV_ID_E610_2_5G_T)
+               hw->phy.eee_speeds_supported = IXGBE_LINK_SPEED_2_5GB_FULL;
+       else
+               hw->phy.eee_speeds_supported = IXGBE_LINK_SPEED_2_5GB_FULL |
+                                              IXGBE_LINK_SPEED_5GB_FULL |
+                                              IXGBE_LINK_SPEED_10GB_FULL;
+
        hw->phy.eee_speeds_advertised = hw->phy.eee_speeds_supported;
 
        return 0;
index ba049b3a9609e88c12cfa1bb4f5bc22620ffa93a..8450094a028a9551209576b5793e4a719da70c1b 100644 (file)
@@ -3541,6 +3541,7 @@ static const struct {
        { IXGBE_LINK_SPEED_100_FULL, ETHTOOL_LINK_MODE_100baseT_Full_BIT },
        { IXGBE_LINK_SPEED_1GB_FULL, ETHTOOL_LINK_MODE_1000baseT_Full_BIT },
        { IXGBE_LINK_SPEED_2_5GB_FULL, ETHTOOL_LINK_MODE_2500baseX_Full_BIT },
+       { IXGBE_LINK_SPEED_5GB_FULL, ETHTOOL_LINK_MODE_5000baseT_Full_BIT },
        { IXGBE_LINK_SPEED_10GB_FULL, ETHTOOL_LINK_MODE_10000baseT_Full_BIT },
 };