]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
TLS: Remove storing of never-read value
authorJouni Malinen <jouni@qca.qualcomm.com>
Mon, 28 Dec 2015 16:15:18 +0000 (18:15 +0200)
committerJouni Malinen <j@w1.fi>
Mon, 28 Dec 2015 16:15:18 +0000 (18:15 +0200)
While this could in theory be claimed to be ready for something to be
added to read a field following the server_write_IV, it does not look
likely that such a use case would show up. As such, just remove the
unused incrementing of pos at the end of the function to get rid of a
useless static analyzer complaint.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
src/tls/tlsv1_client.c

index cc404c156e6586ac6d1ab131316b5800620205af..9bc0d211f48dde4d7ccd57b5ae49547022f88885 100644 (file)
@@ -111,7 +111,6 @@ int tls_derive_keys(struct tlsv1_client *conn,
                pos += conn->rl.iv_size;
                /* server_write_IV */
                os_memcpy(conn->rl.read_iv, pos, conn->rl.iv_size);
-               pos += conn->rl.iv_size;
        } else {
                /*
                 * Use IV field to set the mask value for TLS v1.1. A fixed