]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
ext_lm_group_acl: Improved username handling (#512)
authoraaron-costello <56684862+aaron-costello@users.noreply.github.com>
Fri, 22 Nov 2019 02:44:29 +0000 (02:44 +0000)
committerAmos Jeffries <yadij@users.noreply.github.com>
Mon, 3 Feb 2020 06:36:23 +0000 (19:36 +1300)
helpers/external_acl/LM_group/ext_lm_group_acl.cc

index def9db5ff553ced6e791e8aad1a40a7020964f38..f93fc33e41daa6c372da25e9e0f87ccd6a78d18a 100644 (file)
@@ -343,10 +343,10 @@ Valid_Global_Groups(char *UserName, const char **Groups)
             break;
     }
     if (domain_qualify == NULL) {
-        strcpy(User, NTDomain);
-        strcpy(NTDomain, DefaultDomain);
+        xstrncpy(User, NTDomain, sizeof(User));
+        xstrncpy(NTDomain, DefaultDomain, sizeof(NTDomain));
     } else {
-        strcpy(User, domain_qualify + 1);
+        xstrncpy(User, domain_qualify + 1, sizeof(User));
         domain_qualify[0] = '\0';
         strlwr(NTDomain);
     }