]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/amd/display: Check null pointer before dereferencing se
authorAlex Hung <alex.hung@amd.com>
Thu, 29 Aug 2024 23:30:26 +0000 (17:30 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Oct 2024 13:11:53 +0000 (15:11 +0200)
[ Upstream commit ff599ef6970ee000fa5bc38d02fa5ff5f3fc7575 ]

[WHAT & HOW]
se is null checked previously in the same function, indicating
it might be null; therefore, it must be checked when used again.

This fixes 1 FORWARD_NULL issue reported by Coverity.

Acked-by: Alex Hung <alex.hung@amd.com>
Reviewed-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: Alex Hung <alex.hung@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/amd/display/dc/core/dc.c

index db7a758ab778d5a956add6d3ef884b13beb04b6f..d3d638252e2b9372adbb4d858a1ad82f5f715177 100644 (file)
@@ -1464,7 +1464,7 @@ bool dc_validate_seamless_boot_timing(const struct dc *dc,
                if (crtc_timing->pix_clk_100hz != pix_clk_100hz)
                        return false;
 
-               if (!se->funcs->dp_get_pixel_format)
+               if (!se || !se->funcs->dp_get_pixel_format)
                        return false;
 
                if (!se->funcs->dp_get_pixel_format(