]> git.ipfire.org Git - thirdparty/util-linux.git/commitdiff
tailf: fix open() return value check [coverity scan]
authorKarel Zak <kzak@redhat.com>
Wed, 5 Aug 2015 09:55:56 +0000 (11:55 +0200)
committerKarel Zak <kzak@redhat.com>
Wed, 5 Aug 2015 09:55:56 +0000 (11:55 +0200)
Signed-off-by: Karel Zak <kzak@redhat.com>
text-utils/tailf.c

index d05987af7b8c7f5ebc8b798e45f31fa0e92306f2..ea082c795e976b176e77b21af911b9776d99fa02 100644 (file)
@@ -62,7 +62,8 @@ static void tailf(const char *filename, size_t lines, struct stat *st)
        size_t i;
        char *data;
 
-       if (!(fd = open(filename, O_RDONLY)))
+       fd = open(filename, O_RDONLY);
+       if (fd < 0)
                err(EXIT_FAILURE, _("cannot open %s"), filename);
        data = mmap(0, st->st_size, PROT_READ, MAP_SHARED, fd, 0);
        i = (size_t) st->st_size - 1;