]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
node_device: remove unnecessary checks in virNodeDeviceDefFormat
authorBoris Fiuczynski <fiuczy@linux.ibm.com>
Thu, 22 Feb 2024 13:02:00 +0000 (14:02 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 26 Feb 2024 09:55:55 +0000 (10:55 +0100)
virBufferEscapeString already contains the null check.

Signed-off-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/conf/node_device_conf.c

index a8554102fc25f9bbc5f3f36bdf8c5081c8d3c7d4..febc58afd1e8ae2641b36f1a5bb978cc7ccc1e31 100644 (file)
@@ -672,16 +672,14 @@ virNodeDeviceDefFormat(const virNodeDeviceDef *def)
     virBufferAdjustIndent(&buf, 2);
     virBufferEscapeString(&buf, "<name>%s</name>\n", def->name);
     virBufferEscapeString(&buf, "<path>%s</path>\n", def->sysfs_path);
-    if (def->devnode)
-        virBufferEscapeString(&buf, "<devnode type='dev'>%s</devnode>\n",
-                              def->devnode);
+    virBufferEscapeString(&buf, "<devnode type='dev'>%s</devnode>\n",
+                          def->devnode);
     if (def->devlinks) {
         for (i = 0; def->devlinks[i]; i++)
             virBufferEscapeString(&buf, "<devnode type='link'>%s</devnode>\n",
                                   def->devlinks[i]);
     }
-    if (def->parent)
-        virBufferEscapeString(&buf, "<parent>%s</parent>\n", def->parent);
+    virBufferEscapeString(&buf, "<parent>%s</parent>\n", def->parent);
     if (def->driver) {
         virBufferAddLit(&buf, "<driver>\n");
         virBufferAdjustIndent(&buf, 2);