]> git.ipfire.org Git - thirdparty/vuejs/core.git/commitdiff
polish: warn deprecated beforeDestroy/destroyed lifecycle hooks (#1999)
authorHaoqun Jiang <haoqunjiang@gmail.com>
Tue, 15 Sep 2020 01:47:58 +0000 (09:47 +0800)
committerGitHub <noreply@github.com>
Tue, 15 Sep 2020 01:47:58 +0000 (21:47 -0400)
packages/runtime-core/src/componentOptions.ts

index 672cb8af92a85d90097c1faad98b28b1040ee33e..dec584ae8b49d96ddd4d95f2d7af5db5ab9ab29f 100644 (file)
@@ -316,7 +316,11 @@ interface LegacyOptions<
   updated?(): void
   activated?(): void
   deactivated?(): void
+  /** @deprecated use `beforeUnmount` instead */
+  beforeDestroy?(): void
   beforeUnmount?(): void
+  /** @deprecated use `unmounted` instead */
+  destroyed?(): void
   unmounted?(): void
   renderTracked?: DebuggerHook
   renderTriggered?: DebuggerHook
@@ -393,7 +397,9 @@ export function applyOptions(
     updated,
     activated,
     deactivated,
+    beforeDestroy,
     beforeUnmount,
+    destroyed,
     unmounted,
     render,
     renderTracked,
@@ -631,9 +637,19 @@ export function applyOptions(
   if (renderTriggered) {
     onRenderTriggered(renderTriggered.bind(publicThis))
   }
+  if (__DEV__ && beforeDestroy) {
+    warn(
+      `\`beforeDestroy\` has been renamed to \`beforeUnmount\`.`
+    )
+  }
   if (beforeUnmount) {
     onBeforeUnmount(beforeUnmount.bind(publicThis))
   }
+  if (__DEV__ && destroyed) {
+    warn(
+      `\`destroyed\` has been renamed to \`unmounted\`.`
+    )
+  }
   if (unmounted) {
     onUnmounted(unmounted.bind(publicThis))
   }