]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Fix memory leak in qemuDomainUpdateMemoryDeviceInfo
authorYi Wang <wang.yi59@zte.com.cn>
Thu, 25 May 2017 02:20:16 +0000 (22:20 -0400)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 24 May 2017 14:57:35 +0000 (16:57 +0200)
The @meminfo allocated in qemuMonitorGetMemoryDeviceInfo() may be
lost when qemuDomainObjExitMonitor() failed.

Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_domain.c

index c8dc7481396c467ceeecdd2b46ef4f70805ab080..d9f336b98aedc4d2aa673a5df97c78d71b9844ef 100644 (file)
@@ -5767,8 +5767,10 @@ qemuDomainUpdateMemoryDeviceInfo(virQEMUDriverPtr driver,
 
     rc = qemuMonitorGetMemoryDeviceInfo(priv->mon, &meminfo);
 
-    if (qemuDomainObjExitMonitor(driver, vm) < 0)
+    if (qemuDomainObjExitMonitor(driver, vm) < 0) {
+        virHashFree(meminfo);
         return -1;
+    }
 
     /* if qemu doesn't support the info request, just carry on */
     if (rc == -2)