]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
stupid scan fixes... again
authorAlan T. DeKok <aland@freeradius.org>
Thu, 10 Aug 2017 16:02:38 +0000 (18:02 +0200)
committerAlan T. DeKok <aland@freeradius.org>
Thu, 10 Aug 2017 16:02:38 +0000 (18:02 +0200)
src/modules/rlm_radius/rlm_radius_udp.c

index 4569a8488147822a8761a65861f636e0b0a1ca84..d92806f648b18a3b58fff99feffb0ec34d2e9f7f 100644 (file)
@@ -681,6 +681,9 @@ redo:
        }
 
 done:
+       rad_assert(request != NULL);
+       rad_assert(request->reply != NULL);
+
        /*
         *      We received the response to a Status-Server
         *      check.
@@ -690,7 +693,7 @@ done:
                 *      Delete the reply, but leave the request VPs in
                 *      place.
                 */
-               if (request->reply) fr_pair_list_free(&request->reply->vps);
+               fr_pair_list_free(&request->reply->vps);
 
        } else {
                /*
@@ -1637,6 +1640,9 @@ static rlm_rcode_t mod_push(void *instance, REQUEST *request, rlm_radius_link_t
        if (!c) {
                fr_dlist_t *entry;
 
+               /*
+                *      Only open one new connection at a time.
+                */
                entry = FR_DLIST_FIRST(t->opening);
                if (!entry) mod_connection_alloc(inst, t);