libbpf: Use proper errno value in linker

[ Upstream commit 358b1c0f56ebb6996fcec7dcdcf6bae5dcbc8b6c ]

Return values of the linker_append_sec_data() and the
linker_append_elf_relos() functions are propagated all the
way up to users of libbpf API. In some error cases these
functions return -1 which will be seen as -EPERM from user's
point of view. Instead, return a more reasonable -EINVAL.

Fixes: faf6ed321cf6 ("libbpf: Add BPF static linker APIs")
Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20250430120820.2262053-1-a.s.protopopov@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/tools/lib/bpf/linker.c b/tools/lib/bpf/linker.c
index fc91814a35e8e20d8eb7dec17fa3caec04ec00e8..3e06af5b5352ecc004f91f65ecaf9c387b7851d9 100644 (file)
--- a/tools/lib/bpf/linker.c
+++ b/tools/lib/bpf/linker.c
@@ -1181,7 +1181,7 @@ static int linker_append_sec_data(struct bpf_linker *linker, struct src_obj *obj
                } else {
                        if (!secs_match(dst_sec, src_sec)) {
                                pr_warn("ELF sections %s are incompatible\n", src_sec->sec_name);
-                               return -1;
+                               return -EINVAL;
                        }
 
                        /* "license" and "version" sections are deduped */
@@ -2027,7 +2027,7 @@ static int linker_append_elf_relos(struct bpf_linker *linker, struct src_obj *ob
                        }
                } else if (!secs_match(dst_sec, src_sec)) {
                        pr_warn("sections %s are not compatible\n", src_sec->sec_name);
-                       return -1;
+                       return -EINVAL;
                }
 
                /* add_dst_sec() above could have invalidated linker->secs */