]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: i2c: ov5647: Add V4L2_CID_LINK_FREQUENCY control
authorDave Stevenson <dave.stevenson@raspberrypi.com>
Mon, 22 Dec 2025 08:15:41 +0000 (13:45 +0530)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 14 Jan 2026 22:33:03 +0000 (23:33 +0100)
The link frequency can vary between modes, so add it as a control.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/ov5647.c

index 7003c9922c5be666b4322c8d1dd0a2893c86f253..1041732104fa765053ba79889e11dfeb4d2a1d8f 100644 (file)
@@ -97,6 +97,13 @@ static const char * const ov5647_supply_names[] = {
 
 #define OV5647_NUM_SUPPLIES ARRAY_SIZE(ov5647_supply_names)
 
+#define FREQ_INDEX_FULL                0
+#define FREQ_INDEX_VGA         1
+static const s64 ov5647_link_freqs[] = {
+       [FREQ_INDEX_FULL]       = 218750000,
+       [FREQ_INDEX_VGA]        = 145833300,
+};
+
 struct regval_list {
        u16 addr;
        u8 data;
@@ -106,6 +113,7 @@ struct ov5647_mode {
        struct v4l2_mbus_framefmt       format;
        struct v4l2_rect                crop;
        u64                             pixel_rate;
+       unsigned int                    link_freq_index;
        int                             hts;
        int                             vts;
        const struct regval_list        *reg_list;
@@ -128,6 +136,7 @@ struct ov5647 {
        struct v4l2_ctrl                *exposure;
        struct v4l2_ctrl                *hflip;
        struct v4l2_ctrl                *vflip;
+       struct v4l2_ctrl                *link_freq;
 };
 
 static inline struct ov5647 *to_sensor(struct v4l2_subdev *sd)
@@ -376,6 +385,7 @@ static const struct ov5647_mode ov5647_modes[] = {
                        .height         = 1944
                },
                .pixel_rate     = 87500000,
+               .link_freq_index = FREQ_INDEX_FULL,
                .hts            = 2844,
                .vts            = 0x7b0,
                .reg_list       = ov5647_2592x1944_10bpp,
@@ -397,6 +407,7 @@ static const struct ov5647_mode ov5647_modes[] = {
                        .height         = 1080,
                },
                .pixel_rate     = 87500000,
+               .link_freq_index = FREQ_INDEX_FULL,
                .hts            = 2416,
                .vts            = 0x450,
                .reg_list       = ov5647_1080p30_10bpp,
@@ -418,6 +429,7 @@ static const struct ov5647_mode ov5647_modes[] = {
                        .height         = 1944,
                },
                .pixel_rate     = 87500000,
+               .link_freq_index = FREQ_INDEX_FULL,
                .hts            = 1896,
                .vts            = 0x59b,
                .reg_list       = ov5647_2x2binned_10bpp,
@@ -439,6 +451,7 @@ static const struct ov5647_mode ov5647_modes[] = {
                        .height         = 1920,
                },
                .pixel_rate     = 58333000,
+               .link_freq_index = FREQ_INDEX_VGA,
                .hts            = 1852,
                .vts            = 0x1f8,
                .reg_list       = ov5647_640x480_10bpp,
@@ -927,6 +940,8 @@ static int ov5647_set_pad_fmt(struct v4l2_subdev *sd,
                                         sensor->exposure->minimum,
                                         exposure_max, sensor->exposure->step,
                                         exposure_def);
+
+               __v4l2_ctrl_s_ctrl(sensor->link_freq, mode->link_freq_index);
        }
        *fmt = mode->format;
        /* The code we pass back must reflect the current h/vflips. */
@@ -1231,7 +1246,7 @@ static int ov5647_init_controls(struct ov5647 *sensor)
        int hblank, exposure_max, exposure_def;
        struct device *dev = &client->dev;
 
-       v4l2_ctrl_handler_init(&sensor->ctrls, 13);
+       v4l2_ctrl_handler_init(&sensor->ctrls, 14);
 
        v4l2_ctrl_new_std(&sensor->ctrls, &ov5647_ctrl_ops,
                          V4L2_CID_AUTOGAIN, 0, 1, 1, 0);
@@ -1287,6 +1302,14 @@ static int ov5647_init_controls(struct ov5647 *sensor)
        sensor->vflip = v4l2_ctrl_new_std(&sensor->ctrls, &ov5647_ctrl_ops,
                                          V4L2_CID_VFLIP, 0, 1, 1, 0);
 
+       sensor->link_freq =
+               v4l2_ctrl_new_int_menu(&sensor->ctrls, NULL, V4L2_CID_LINK_FREQ,
+                                      ARRAY_SIZE(ov5647_link_freqs) - 1,
+                                      sensor->mode->link_freq_index,
+                                      ov5647_link_freqs);
+       if (sensor->link_freq)
+               sensor->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY;
+
        v4l2_fwnode_device_parse(dev, &props);
 
        v4l2_ctrl_new_fwnode_properties(&sensor->ctrls, &ov5647_ctrl_ops,