tools/cgcreate: use exit code 129 on invalid usage

The exit code 1 refers to general error and using -1 wraps to
255, both codes do not signify bad arguments. Let's use exit code 129
(EXIT_BADARGS) for hinting to the users about invalid usage.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

diff --git a/src/tools/cgcreate.c b/src/tools/cgcreate.c
index 96d015a9f6733197eed33d4ebf17626d2c28c3af..2ef8d9976639590a0259d139549cbadf91be5bed 100644 (file)
--- a/src/tools/cgcreate.c
+++ b/src/tools/cgcreate.c
@@ -80,7 +80,7 @@ int main(int argc, char *argv[])
        /* no parametr on input */
        if (argc < 2) {
                usage(1, argv[0]);
-               return -1;
+               exit(EXIT_BADARGS);
        }
 
        cgroup_list = calloc(capacity, sizeof(struct cgroup_group_spec *));
@@ -112,7 +112,7 @@ int main(int argc, char *argv[])
                        if (ret) {
                                err("%s: cgroup controller and path parsing failed (%s)\n",
                                    argv[0], argv[optind]);
-                               ret = -1;
+                               ret = EXIT_BADARGS;
                                goto err;
                        }
                        break;
@@ -136,7 +136,7 @@ int main(int argc, char *argv[])
                        break;
                default:
                        usage(1, argv[0]);
-                       ret = -1;
+                       ret = EXIT_BADARGS;
                        goto err;
                }
        }
@@ -144,7 +144,7 @@ int main(int argc, char *argv[])
        /* no cgroup name */
        if (argv[optind]) {
                err("%s: wrong arguments (%s)\n", argv[0], argv[optind]);
-               ret = -1;
+               ret = EXIT_BADARGS;
                goto err;
        }