]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
irqdomain: Make irq_domain_create_hierarchy() an inline
authorJiri Slaby (SUSE) <jirislaby@kernel.org>
Wed, 19 Mar 2025 09:29:05 +0000 (10:29 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 16 May 2025 19:06:08 +0000 (21:06 +0200)
There is no reason to export the function as an extra symbol. It is
simple enough and is just a wrapper to already exported functions.

Therefore, switch the exported function to an inline.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250319092951.37667-13-jirislaby@kernel.org
include/linux/irqdomain.h
kernel/irq/irqdomain.c

index 91ed86feac07ab1333ccb817c92f8f7545f85d15..6e9a5ec2986f1d005b819bb3451398dffc6553cb 100644 (file)
@@ -591,12 +591,45 @@ void irq_domain_set_info(struct irq_domain *domain, unsigned int virq,
                         void *handler_data, const char *handler_name);
 void irq_domain_reset_irq_data(struct irq_data *irq_data);
 #ifdef CONFIG_IRQ_DOMAIN_HIERARCHY
-struct irq_domain *irq_domain_create_hierarchy(struct irq_domain *parent,
-                                              unsigned int flags,
-                                              unsigned int size,
-                                              struct fwnode_handle *fwnode,
-                                              const struct irq_domain_ops *ops,
-                                              void *host_data);
+/**
+ * irq_domain_create_hierarchy - Add a irqdomain into the hierarchy
+ * @parent:    Parent irq domain to associate with the new domain
+ * @flags:     Irq domain flags associated to the domain
+ * @size:      Size of the domain. See below
+ * @fwnode:    Optional fwnode of the interrupt controller
+ * @ops:       Pointer to the interrupt domain callbacks
+ * @host_data: Controller private data pointer
+ *
+ * If @size is 0 a tree domain is created, otherwise a linear domain.
+ *
+ * If successful the parent is associated to the new domain and the
+ * domain flags are set.
+ * Returns pointer to IRQ domain, or NULL on failure.
+ */
+static inline struct irq_domain *irq_domain_create_hierarchy(struct irq_domain *parent,
+                                           unsigned int flags,
+                                           unsigned int size,
+                                           struct fwnode_handle *fwnode,
+                                           const struct irq_domain_ops *ops,
+                                           void *host_data)
+{
+       struct irq_domain_info info = {
+               .fwnode         = fwnode,
+               .size           = size,
+               .hwirq_max      = size,
+               .ops            = ops,
+               .host_data      = host_data,
+               .domain_flags   = flags,
+               .parent         = parent,
+       };
+       struct irq_domain *d;
+
+       if (!info.size)
+               info.hwirq_max = ~0U;
+
+       d = irq_domain_instantiate(&info);
+       return IS_ERR(d) ? NULL : d;
+}
 
 static inline struct irq_domain *irq_domain_add_hierarchy(struct irq_domain *parent,
                                            unsigned int flags,
index 0eb99d247cebbe4ad518ed23d802fd4edb53f903..74ad4a8fb4f780f0c6e9d28f3bc6b7643bbd27bc 100644 (file)
@@ -1308,47 +1308,6 @@ void irq_domain_reset_irq_data(struct irq_data *irq_data)
 EXPORT_SYMBOL_GPL(irq_domain_reset_irq_data);
 
 #ifdef CONFIG_IRQ_DOMAIN_HIERARCHY
-/**
- * irq_domain_create_hierarchy - Add a irqdomain into the hierarchy
- * @parent:    Parent irq domain to associate with the new domain
- * @flags:     Irq domain flags associated to the domain
- * @size:      Size of the domain. See below
- * @fwnode:    Optional fwnode of the interrupt controller
- * @ops:       Pointer to the interrupt domain callbacks
- * @host_data: Controller private data pointer
- *
- * If @size is 0 a tree domain is created, otherwise a linear domain.
- *
- * If successful the parent is associated to the new domain and the
- * domain flags are set.
- * Returns pointer to IRQ domain, or NULL on failure.
- */
-struct irq_domain *irq_domain_create_hierarchy(struct irq_domain *parent,
-                                           unsigned int flags,
-                                           unsigned int size,
-                                           struct fwnode_handle *fwnode,
-                                           const struct irq_domain_ops *ops,
-                                           void *host_data)
-{
-       struct irq_domain_info info = {
-               .fwnode         = fwnode,
-               .size           = size,
-               .hwirq_max      = size,
-               .ops            = ops,
-               .host_data      = host_data,
-               .domain_flags   = flags,
-               .parent         = parent,
-       };
-       struct irq_domain *d;
-
-       if (!info.size)
-               info.hwirq_max = ~0U;
-
-       d = irq_domain_instantiate(&info);
-       return IS_ERR(d) ? NULL : d;
-}
-EXPORT_SYMBOL_GPL(irq_domain_create_hierarchy);
-
 static void irq_domain_insert_irq(int virq)
 {
        struct irq_data *data;