]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
misc: pci_endpoint_test: Fix potential truncation in pci_endpoint_test_probe()
authorNiklas Cassel <cassel@kernel.org>
Thu, 23 Jan 2025 10:31:28 +0000 (11:31 +0100)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Sat, 8 Mar 2025 14:36:05 +0000 (14:36 +0000)
Increase the size of the string buffer to avoid potential truncation in
pci_endpoint_test_probe().

This fixes the following build warning when compiling with W=1:

  drivers/misc/pci_endpoint_test.c:29:49: note: directive argument in the range [0, 2147483647]
     29 | #define DRV_MODULE_NAME                         "pci-endpoint-test"
        |                                                 ^~~~~~~~~~~~~~~~~~~
  drivers/misc/pci_endpoint_test.c:998:38: note: in expansion of macro ‘DRV_MODULE_NAME’
    998 |         snprintf(name, sizeof(name), DRV_MODULE_NAME ".%d", id);
        |                                      ^~~~~~~~~~~~~~~
  drivers/misc/pci_endpoint_test.c:998:9: note: ‘snprintf’ output between 20 and 29 bytes into a destination of size 24
    998 |         snprintf(name, sizeof(name), DRV_MODULE_NAME ".%d", id);
        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Niklas Cassel <cassel@kernel.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20250123103127.3581432-2-cassel@kernel.org
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
[kwilczynski: commit log]
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
drivers/misc/pci_endpoint_test.c

index 7584d1876859848ab2cb14dd99d12b0d4a9fb3b3..0fa5ddd1969b288d8c0de1a357c5bce82a94023f 100644 (file)
@@ -910,7 +910,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev,
 {
        int ret;
        int id;
-       char name[24];
+       char name[29];
        enum pci_barno bar;
        void __iomem *base;
        struct device *dev = &pdev->dev;