]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
dmaengine: ti: dma-crossbar: fix device leak on dra7x route allocation
authorJohan Hovold <johan@kernel.org>
Mon, 17 Nov 2025 16:12:55 +0000 (17:12 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Feb 2026 15:44:02 +0000 (16:44 +0100)
commit dc7e44db01fc2498644e3106db3e62a9883a93d5 upstream.

Make sure to drop the reference taken when looking up the crossbar
platform device during dra7x route allocation.

Note that commit 615a4bfc426e ("dmaengine: ti: Add missing put_device in
ti_dra7_xbar_route_allocate") fixed the leak in the error paths but the
reference is still leaking on successful allocation.

Fixes: a074ae38f859 ("dmaengine: Add driver for TI DMA crossbar on DRA7x")
Fixes: 615a4bfc426e ("dmaengine: ti: Add missing put_device in ti_dra7_xbar_route_allocate")
Cc: stable@vger.kernel.org # 4.2: 615a4bfc426e
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20251117161258.10679-14-johan@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/dma/ti/dma-crossbar.c

index f744ddbbbad7fa35e41bfd39915feb2d9cfcae73..1bc730d479dff356bfa9120693319df3d3f74b28 100644 (file)
@@ -287,6 +287,8 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec,
 
        ti_dra7_xbar_write(xbar->iomem, map->xbar_out, map->xbar_in);
 
+       put_device(&pdev->dev);
+
        return map;
 }