]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
admin: fix memory leak of typed parameters getting client info
authorDaniel P. Berrangé <berrange@redhat.com>
Mon, 30 Sep 2019 15:56:33 +0000 (16:56 +0100)
committerDaniel P. Berrangé <berrange@redhat.com>
Tue, 1 Oct 2019 11:55:59 +0000 (12:55 +0100)
In the error code path, the temporary parameters are not freed.

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
src/admin/admin_server.c

index 248df3f7959b5df9fbac871bd683a2427355e319..0d6091937d7eaf69c6bb6dc2aca954dc40b88a01 100644 (file)
@@ -310,6 +310,8 @@ adminClientGetInfo(virNetServerClientPtr client,
     ret = 0;
 
  cleanup:
+    if (tmpparams)
+        virTypedParamsFree(tmpparams, *nparams);
     virObjectUnref(identity);
     VIR_FREE(sock_addr);
     return ret;