]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
phy: phy-can-transceiver: Introduce can_transceiver_priv
authorPeng Fan <peng.fan@nxp.com>
Wed, 1 Oct 2025 13:22:33 +0000 (21:22 +0800)
committerVinod Koul <vkoul@kernel.org>
Wed, 12 Nov 2025 14:41:15 +0000 (20:11 +0530)
To prepare for dual-channel phy support, introduce can_transceiver_priv as
a higher level encapsulation for phy.

No functional changes.

Reviewed-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Link: https://patch.msgid.link/20251001-can-v7-2-fad29efc3884@nxp.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/phy-can-transceiver.c

index f59caff4b3d4c267feca4220bf1547b6fad08f95..b06ba42854c194b5aec1ca1a41db2c65862c4529 100644 (file)
@@ -23,17 +23,24 @@ struct can_transceiver_phy {
        struct phy *generic_phy;
        struct gpio_desc *standby_gpio;
        struct gpio_desc *enable_gpio;
+       struct can_transceiver_priv *priv;
+};
+
+struct can_transceiver_priv {
        struct mux_state *mux_state;
+       int num_ch;
+       struct can_transceiver_phy can_transceiver_phy[] __counted_by(num_ch);
 };
 
 /* Power on function */
 static int can_transceiver_phy_power_on(struct phy *phy)
 {
        struct can_transceiver_phy *can_transceiver_phy = phy_get_drvdata(phy);
+       struct can_transceiver_priv *priv = can_transceiver_phy->priv;
        int ret;
 
-       if (can_transceiver_phy->mux_state) {
-               ret = mux_state_select(can_transceiver_phy->mux_state);
+       if (priv->mux_state) {
+               ret = mux_state_select(priv->mux_state);
                if (ret) {
                        dev_err(&phy->dev, "Failed to select CAN mux: %d\n", ret);
                        return ret;
@@ -51,13 +58,14 @@ static int can_transceiver_phy_power_on(struct phy *phy)
 static int can_transceiver_phy_power_off(struct phy *phy)
 {
        struct can_transceiver_phy *can_transceiver_phy = phy_get_drvdata(phy);
+       struct can_transceiver_priv *priv = can_transceiver_phy->priv;
 
        if (can_transceiver_phy->standby_gpio)
                gpiod_set_value_cansleep(can_transceiver_phy->standby_gpio, 1);
        if (can_transceiver_phy->enable_gpio)
                gpiod_set_value_cansleep(can_transceiver_phy->enable_gpio, 0);
-       if (can_transceiver_phy->mux_state)
-               mux_state_deselect(can_transceiver_phy->mux_state);
+       if (priv->mux_state)
+               mux_state_deselect(priv->mux_state);
 
        return 0;
 }
@@ -108,6 +116,7 @@ static int can_transceiver_phy_probe(struct platform_device *pdev)
        struct phy_provider *phy_provider;
        struct device *dev = &pdev->dev;
        struct can_transceiver_phy *can_transceiver_phy;
+       struct can_transceiver_priv *priv;
        const struct can_transceiver_data *drvdata;
        const struct of_device_id *match;
        struct phy *phy;
@@ -115,20 +124,25 @@ static int can_transceiver_phy_probe(struct platform_device *pdev)
        struct gpio_desc *enable_gpio;
        struct mux_state *mux_state;
        u32 max_bitrate = 0;
-       int err;
-
-       can_transceiver_phy = devm_kzalloc(dev, sizeof(struct can_transceiver_phy), GFP_KERNEL);
-       if (!can_transceiver_phy)
-               return -ENOMEM;
+       int err, num_ch = 1;
 
        match = of_match_node(can_transceiver_phy_ids, pdev->dev.of_node);
        drvdata = match->data;
 
+       priv = devm_kzalloc(dev, struct_size(priv, can_transceiver_phy, num_ch), GFP_KERNEL);
+       if (!priv)
+               return -ENOMEM;
+
+       priv->num_ch = num_ch;
+       platform_set_drvdata(pdev, priv);
+       can_transceiver_phy = &priv->can_transceiver_phy[0];
+       can_transceiver_phy->priv = priv;
+
        mux_state = devm_mux_state_get_optional(dev, NULL);
        if (IS_ERR(mux_state))
                return PTR_ERR(mux_state);
 
-       can_transceiver_phy->mux_state = mux_state;
+       priv->mux_state = mux_state;
 
        phy = devm_phy_create(dev, dev->of_node,
                              &can_transceiver_phy_ops);